Re: [PATCH] remote show: fix the -n option

Hi,

On Mon, 9 Jun 2008, Olivier Marin wrote:

Olivier Marin a écrit :

quoted

Johannes Schindelin a écrit :

quoted

I would not like to remove the got_states.  I think this is the wrong 
direction.  Rather change the die() into a return error().

OK, I will try that.

After reading some more code, I can say that changing die() in return 
error() won't change anything here because, in get_ref_states() we only 
die() if get_fetch_map() return an error. But guess what, 
get_fetch_map() never return an error. It just die() or return 0. And I 
can't change it without breaking "clone" and "fetch".

So you think it is okay, because the result is the same?  I think not.  I 
think this is exactly the way of thinking that makes reusing unlibified 
parts of Git's source code hard.  I think that this is exactly the style 
of programming I try to avoid, because it messes up clean concepts.

And I am utterly embarassed that we are talking about my code here.

Ciao,
Dscho