Testing if gitweb handles filenames with spaces, filenames with plus
sign ('+') which encodes spaces in CGI parameters (in URLs), and
filenames with Unicode characters should be handled by gitweb tests.
Those files are remainder of the time when gitweb was project on its
own, not a part of git (with its testsuite).
Signed-off-by: Jakub Narebski <redacted>
---
On Sat, 31 May 2008 19:37:48 +0200, Steffen Prohaska wrote:On May 29, 2008, at 4:58 PM, Wincent Colaiuta wrote:
[...]
quoted
If the powers that be will accept a change that removes M�rchen I'll
be more than happy to whip up a patch.
Unicode normalization is tested in t/t0050-filesystem.sh, which
reports on HFS+:
* still broken 8: rename (silent unicode normalization)
* still broken 9: merge (silent unicode normalization)
I believe there is no value in keeping gitweb/test/M�rchen for the
reason of testing HFS+, so I vote for removing it, unless there
is another good reason for keeping it.
So here it is, the patch to remove offending file; well: the whole
gitweb/test/ directory.
"gitweb/test/M\303\244rchen" | 2 --
gitweb/test/file with spaces | 4 ----
gitweb/test/file+plus+sign | 6 ------
3 files changed, 0 insertions(+), 12 deletions(-)
delete mode 100644 gitweb/test/Märchen
delete mode 100644 gitweb/test/file with spaces
delete mode 100644 gitweb/test/file+plus+sign
diff --git "a/gitweb/test/M\303\244rchen" "b/gitweb/test/M\303\244rchen"
deleted file mode 100644
index 8f7a1d3..0000000
--- "a/gitweb/test/M\303\244rchen"
+++ /dev/null
@@ -1,2 +0,0 @@
-Märchen
-M�rchen
diff --git a/gitweb/test/file with spaces b/gitweb/test/file with spaces
deleted file mode 100644
index f108543..0000000
--- a/gitweb/test/file with spaces
+++ /dev/null
@@ -1,4 +0,0 @@
-This
-filename
-contains
-spaces.
diff --git a/gitweb/test/file+plus+sign b/gitweb/test/file+plus+sign
deleted file mode 100644
index fd05278..0000000
--- a/gitweb/test/file+plus+sign
+++ /dev/null
@@ -1,6 +0,0 @@
-This
-filename
-contains
-+
-plus
-chars.