From: Junio C Hamano <hidden> Date: 2016-06-15 22:44:39
Mark Levedahl [off-list ref] writes:
As this commit is part of the published master branch, I am not sure
the correct resolution: leaving this commit in place means that any
commit between it and a commit fixing this will always cause an error
on Cygwin / Windows. Of course, it *is* on the published master branch.
Some broken filesystems may not be capable of checking out and using
project files. Too bad.
It's not a big deal. It is not limited to this project. We just fix them
or work them around and move on.
Perhaps we should remove the infamous gitweb/test/Märchen file while we
are at it? I do not think the file is ever used.
El 28/5/2008, a las 8:12, Junio C Hamano escribió:
Mark Levedahl [off-list ref] writes:
quoted
As this commit is part of the published master branch, I am not sure
the correct resolution: leaving this commit in place means that any
commit between it and a commit fixing this will always cause an error
on Cygwin / Windows. Of course, it *is* on the published master
branch.
Some broken filesystems may not be capable of checking out and using
project files. Too bad.
It's not a big deal. It is not limited to this project. We just
fix them
or work them around and move on.
Perhaps we should remove the infamous gitweb/test/Märchen file while
we
are at it? I do not think the file is ever used.
I for one would love to see it go, seeing as I live in the ghetto that
is HFS+ and am constantly annoyed by it cluttering up my status output
with spurious content.
I understand that the reason it lives in the tree is precisely to
discover problems with such filesystems, but the problem is well and
truly discovered by now and I'd much rather see this kind of thing
tested from within the test suite rather than every time I do "git
status" or "git checkout".
Cheers,
Wincent
El 28/5/2008, a las 8:12, Junio C Hamano escribió:
quoted
Perhaps we should remove the infamous gitweb/test/Märchen file
[...] I'd much rather see this kind of thing
tested from within the test suite rather than every time I do "git
status" or "git checkout".
I don't believe the Märchen file is actually used in any test code, so
removing it should be fine. If/when we actually write test code for
gitweb, it seems to me that we might as well generate such test files on
the fly from within the test suite, rather than having them in the file
system permanently.
Best,
Lea
El 28/5/2008, a las 8:12, Junio C Hamano escribió:
quoted
Perhaps we should remove the infamous gitweb/test/Märchen file
[...] I'd much rather see this kind of thing tested from within
the test suite rather than every time I do "git status" or "git
checkout".
I don't believe the Märchen file is actually used in any test code,
so removing it should be fine. If/when we actually write test code
for gitweb, it seems to me that we might as well generate such test
files on the fly from within the test suite, rather than having them
in the file system permanently.
Yes, that's exactly what I intended my comment to imply. Test at test
time, not every time I do "git status" and "git checkout" etc.
Cheers,
Wincent
Mark Levedahl [off-list ref] writes:
> As this commit is part of the published master branch, I am not sure
> the correct resolution: leaving this commit in place means that any
> commit between it and a commit fixing this will always cause an error
> on Cygwin / Windows. Of course, it *is* on the published master branch.
Some broken filesystems may not be capable of checking out and using
project files. Too bad.
It's not a big deal. It is not limited to this project. We just fix them
or work them around and move on.
Perhaps we should remove the infamous gitweb/test/Märchen file while we
are at it? I do not think the file is ever used.
As an unhappy Windows user myself (sometimes), I think it might be
better to simply fix git to *survive* failing to create files like
'nul' on Win32, rather than trying to *fix* such files in the repo.
It sounds (from the original post) like git has a *fatal* error
("cannot be checked out on cygwin") when trying to create 'nul', which
might be overkill.
The argument about rewriting the git history for this one file is
mostly predicated on the fact that you can't git-bisect if this file
exists. Rather than making the file not exist, it might be better to
make git work when it does.
Have fun,
Avery
From: Jakub Narebski <hidden> Date: 2016-06-15 22:44:39
Wincent Colaiuta wrote:
El 28/5/2008, a las 17:53, Lea Wiemann escribió:
quoted
Wincent Colaiuta wrote:
quoted
El 28/5/2008, a las 8:12, Junio C Hamano escribió:
quoted
Perhaps we should remove the infamous gitweb/test/Märchen file
[...] I'd much rather see this kind of thing tested from within
the test suite rather than every time I do "git status" or "git
checkout".
I don't believe the Märchen file is actually used in any test code,
so removing it should be fine. If/when we actually write test code
for gitweb, it seems to me that we might as well generate such test
files on the fly from within the test suite, rather than having them
in the file system permanently.
Yes, that's exactly what I intended my comment to imply. Test at test
time, not every time I do "git status" and "git checkout" etc.
I think it is remainder (the whole gitweb/test/ directory) from the
times when gitweb was separate project, and not part of git.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
From: Johannes Schindelin <hidden> Date: 2016-06-15 22:44:39
Hi,
On Wed, 28 May 2008, Wincent Colaiuta wrote:
El 28/5/2008, a las 8:12, Junio C Hamano escribió:
quoted
Perhaps we should remove the infamous gitweb/test/Märchen file while we
are at it? I do not think the file is ever used.
I for one would love to see it go, seeing as I live in the ghetto that
is HFS+ and am constantly annoyed by it cluttering up my status output
with spurious content.
I understand that the reason it lives in the tree is precisely to
discover problems with such filesystems, but the problem is well and
truly discovered by now and I'd much rather see this kind of thing
tested from within the test suite rather than every time I do "git
status" or "git checkout".
Probably you are not enoyed enough to just go and fix it.
Ciao,
Dscho
El 29/5/2008, a las 15:22, Johannes Schindelin escribió:
Hi,
On Wed, 28 May 2008, Wincent Colaiuta wrote:
quoted
El 28/5/2008, a las 8:12, Junio C Hamano escribió:
quoted
Perhaps we should remove the infamous gitweb/test/Märchen file
while we
are at it? I do not think the file is ever used.
I for one would love to see it go, seeing as I live in the ghetto
that
is HFS+ and am constantly annoyed by it cluttering up my status
output
with spurious content.
I understand that the reason it lives in the tree is precisely to
discover problems with such filesystems, but the problem is well and
truly discovered by now and I'd much rather see this kind of thing
tested from within the test suite rather than every time I do "git
status" or "git checkout".
Probably you are not enoyed enough to just go and fix it.
No, that's not actually the case. In reality I was pleasantly
surprised when Junio commented that "perhaps we should remove" that
file; I had always gotten the impression from this list that such a
change would be unwelcome because it's easier to just blame the users
of bad filesystems for choosing those filesystems. I also remember a
comment from Linus to the effect that that file was kept in the tree
precisely _because_ it helped us discover such file systems.
Unfortunately I can't find that message right now but I think it was
about 6 months ago.
If the powers that be will accept a change that removes Märchen I'll
be more than happy to whip up a patch.
Wincent
From: Johannes Schindelin <hidden> Date: 2016-06-15 22:44:39
Hi,
On Thu, 29 May 2008, Wincent Colaiuta wrote:
El 29/5/2008, a las 15:22, Johannes Schindelin escribió:
quoted
Probably you are not enoyed enough to just go and fix it.
No, that's not actually the case. In reality I was pleasantly surprised
when Junio commented that "perhaps we should remove" that file;
You misunderstood me. I was not talking about "fixing" it by removing the
file, and papering over the UTF-8 issue on HFS+.
I was talking about fixing it by handling UTF-8 in a way that is
compatible with (maybe stupid, but that cannot be helped) HFS+.
Ciao,
Dscho
El 29/5/2008, a las 18:05, Johannes Schindelin escribió:
Hi,
On Thu, 29 May 2008, Wincent Colaiuta wrote:
quoted
El 29/5/2008, a las 15:22, Johannes Schindelin escribió:
quoted
Probably you are not enoyed enough to just go and fix it.
No, that's not actually the case. In reality I was pleasantly
surprised
when Junio commented that "perhaps we should remove" that file;
You misunderstood me. I was not talking about "fixing" it by
removing the
file, and papering over the UTF-8 issue on HFS+.
I was talking about fixing it by handling UTF-8 in a way that is
compatible with (maybe stupid, but that cannot be helped) HFS+.
Ah, ok. That's way beyond my skill set and a completely different
subject. I was responding to Junio's comment about _removing_ the file.
Wincent
On May 29, 2008, at 4:58 PM, Wincent Colaiuta wrote:
El 29/5/2008, a las 15:22, Johannes Schindelin escribió:
quoted
On Wed, 28 May 2008, Wincent Colaiuta wrote:
quoted
El 28/5/2008, a las 8:12, Junio C Hamano escribió:
quoted
Perhaps we should remove the infamous gitweb/test/Märchen file
while we
are at it? I do not think the file is ever used.
I for one would love to see it go, seeing as I live in the ghetto
that
is HFS+ and am constantly annoyed by it cluttering up my status
output
with spurious content.
I understand that the reason it lives in the tree is precisely to
discover problems with such filesystems, but the problem is well and
truly discovered by now and I'd much rather see this kind of thing
tested from within the test suite rather than every time I do "git
status" or "git checkout".
Probably you are not enoyed enough to just go and fix it.
[...]
If the powers that be will accept a change that removes Märchen I'll
be more than happy to whip up a patch.
Unicode normalization is tested in t/t0050-filesystem.sh, which
reports on HFS+:
* still broken 8: rename (silent unicode normalization)
* still broken 9: merge (silent unicode normalization)
I believe there is no value in keeping gitweb/test/Märchen for the
reason of testing HFS+, so I vote for removing it, unless there
is another good reason for keeping it.
Steffen
From: Jakub Narebski <hidden> Date: 2016-06-15 22:44:40
Testing if gitweb handles filenames with spaces, filenames with plus
sign ('+') which encodes spaces in CGI parameters (in URLs), and
filenames with Unicode characters should be handled by gitweb tests.
Those files are remainder of the time when gitweb was project on its
own, not a part of git (with its testsuite).
Signed-off-by: Jakub Narebski <redacted>
---
On Sat, 31 May 2008 19:37:48 +0200, Steffen Prohaska wrote:
On May 29, 2008, at 4:58 PM, Wincent Colaiuta wrote:
[...]
quoted
If the powers that be will accept a change that removes M�rchen I'll
be more than happy to whip up a patch.
Unicode normalization is tested in t/t0050-filesystem.sh, which
reports on HFS+:
* still broken 8: rename (silent unicode normalization)
* still broken 9: merge (silent unicode normalization)
I believe there is no value in keeping gitweb/test/M�rchen for the
reason of testing HFS+, so I vote for removing it, unless there
is another good reason for keeping it.
So here it is, the patch to remove offending file; well: the whole
gitweb/test/ directory.
"gitweb/test/M\303\244rchen" | 2 --
gitweb/test/file with spaces | 4 ----
gitweb/test/file+plus+sign | 6 ------
3 files changed, 0 insertions(+), 12 deletions(-)
delete mode 100644 gitweb/test/Märchen
delete mode 100644 gitweb/test/file with spaces
delete mode 100644 gitweb/test/file+plus+sign
El 31/5/2008, a las 20:28, Jakub Narebski escribió:
Testing if gitweb handles filenames with spaces, filenames with plus
sign ('+') which encodes spaces in CGI parameters (in URLs), and
filenames with Unicode characters should be handled by gitweb tests.
Those files are remainder of the time when gitweb was project on its
own, not a part of git (with its testsuite).
Signed-off-by: Jakub Narebski <redacted>
From: Johannes Schindelin <hidden> Date: 2016-06-15 22:44:40
Hi,
On Sat, 31 May 2008, Wincent Colaiuta wrote:
El 31/5/2008, a las 20:28, Jakub Narebski escribió:
quoted
Testing if gitweb handles filenames with spaces, filenames with plus
sign ('+') which encodes spaces in CGI parameters (in URLs), and
filenames with Unicode characters should be handled by gitweb tests.
Those files are remainder of the time when gitweb was project on its
own, not a part of git (with its testsuite).
Signed-off-by: Jakub Narebski <redacted>
Ack.
And I thought "Ack" was reserved for the people who are considered the
primary authors of the patched code...
Ciao,
Dscho
From: Jakub Narebski <hidden> Date: 2016-06-15 22:44:40
On Sun, 1 Jan 2008, Johannes Schindelin wrote:
On Sat, 31 May 2008, Wincent Colaiuta wrote:
quoted
El 31/5/2008, a las 20:28, Jakub Narebski escribió:
quoted
Testing if gitweb handles filenames with spaces, filenames with plus
sign ('+') which encodes spaces in CGI parameters (in URLs), and
filenames with Unicode characters should be handled by gitweb tests.
Those files are remainder of the time when gitweb was project on its
own, not a part of git (with its testsuite).
Signed-off-by: Jakub Narebski <redacted>
Ack.
And I thought "Ack" was reserved for the people who are considered the
primary authors of the patched code...
Unfortunately, as far as I know, primary and only author of those
lines of code, maintainer of gitweb when it was separate project,
Kay Sievers, is no longer active in git development.
--
Jakub Narebski
Poland
From: Kay Sievers <hidden> Date: 2016-06-15 22:44:40
On Sun, 2008-06-01 at 02:19 +0200, Jakub Narebski wrote:
On Sun, 1 Jan 2008, Johannes Schindelin wrote:
quoted
On Sat, 31 May 2008, Wincent Colaiuta wrote:
quoted
El 31/5/2008, a las 20:28, Jakub Narebski escribió:
quoted
Testing if gitweb handles filenames with spaces, filenames with plus
sign ('+') which encodes spaces in CGI parameters (in URLs), and
filenames with Unicode characters should be handled by gitweb tests.
Those files are remainder of the time when gitweb was project on its
own, not a part of git (with its testsuite).
Signed-off-by: Jakub Narebski <redacted>
Ack.
And I thought "Ack" was reserved for the people who are considered the
primary authors of the patched code...
Unfortunately, as far as I know, primary and only author of those
lines of code, maintainer of gitweb when it was separate project,
Kay Sievers, is no longer active in git development.
Sure, feel free to do whatever makes sense, there is no reason to get my
ACK, as I'm not actively working on it anymore. I'm glad, you guys take
care of gitweb these days, and it has improved a lot since then.
Thanks,
Kay
El 1/6/2008, a las 1:19, Johannes Schindelin escribió:
Hi,
On Sat, 31 May 2008, Wincent Colaiuta wrote:
quoted
El 31/5/2008, a las 20:28, Jakub Narebski escribió:
quoted
Testing if gitweb handles filenames with spaces, filenames with plus
sign ('+') which encodes spaces in CGI parameters (in URLs), and
filenames with Unicode characters should be handled by gitweb tests.
Those files are remainder of the time when gitweb was project on its
own, not a part of git (with its testsuite).
Signed-off-by: Jakub Narebski <redacted>
Ack.
And I thought "Ack" was reserved for the people who are considered the
primary authors of the patched code...
I had no idea. Thanks for letting me know.
Wincent