Thread (11 messages) flat view 11 messages, 4 authors, 2016-06-15

Re: [PATCH 2/2] Fix t3404 assumption that `wc -l` does not use whitespace.

From: Jeff King <hidden>
Date: 2016-06-15 22:44:32

On Sun, Apr 27, 2008 at 11:32:24AM -0400, Brian Gernhardt wrote:
Eh, not everyone's perfect.  I would have used `rev` instead of `tac` and 
still been wrong for Solaris.  But it seems that the `wc -l` whitespace 
issue seems to hit nearly everyone at some point, so I thought it would be 
a good candidate for CodingStyle.

Personally, I'd love to have the time to review all the patches to catch 
these issues while still on the list instead of waiting until they hit 
next and I tried to compile it.  But I don't always notice, have time, or 
care myself.
BTW, how did you discover this bug? Through normal use, or was there a
failing test?

If a failing test, then I wonder if we could get a few people to set up
automated tests on alternate platforms. IIRC, Junio makes sure that
master always passes test on his Linux box and KO (Debian and Redhat, I
think?). Other platforms could "git pull && make test" daily. I could
probably do Solaris (once I get the tests to complete pass at all!) and
FreeBSD 6.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help