Re: [PATCH v3 1/4] config.c: Add git_config_bool_or_int to handle bool/int variable

On Sun, Apr 13, 2008 at 2:26 PM, Junio C Hamano [off-list ref] wrote:

Ping Yin [off-list ref] writes:

 -int git_config_bool(const char *name, const char *value)

+int git_config_bool_or_int(const char *name, const char *value, int *is_bool)
  {
 +       *is_bool = 1;
        if (!value)
                return 1;
        if (!*value)
 @@ -313,9 +314,16 @@ int git_config_bool(const char *name, const char *value)

                return 1;
        if (!strcasecmp(value, "false") || !strcasecmp(value, "no"))
                return 0;
 +       *is_bool = 0;

        return git_config_int(name, value) != 0;
  }

Should return an interger if *is_bool==0
s/!=0//

 +int git_config_bool(const char *name, const char *value)
 +{
 +       int discard;
 +       return git_config_bool_or_int(name, value, &discard);


+}
 +
  int git_config_string(const char **dest, const char *var, const char *value)
  {
        if (!value)

-- 
Ping Yin