Thread (11 messages) flat view 11 messages, 2 authors, 2016-06-15

Re: [PATCH v2 2/4] builtin-status: submodule summary support

From: Ping Yin <hidden>
Date: 2016-06-15 22:44:22
Subsystem: the rest · Maintainer: Linus Torvalds

On Thu, Mar 13, 2008 at 10:11 PM, Johannes Sixt [off-list ref] wrote:
Ping Yin schrieb:

 >       wt_status_print_changed(s);
 > +     // must flush s->fp since following call will write to s->fp in a child process
 > +     fflush(s->fp);
 > +     wt_status_print_submodule_summary(s);
 >       wt_status_print_untracked(s);

 But then we don't need the fflush() here. Right?
You are right.
diff --git a/wt-status.c b/wt-status.c
index 2f47e36..468c14c 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -352,8 +352,6 @@ void wt_status_print(struct wt_status *s)
        }

        wt_status_print_changed(s);
-       // must flush s->fp since following call will write to s->fp
in a child process
-       fflush(s->fp);
        wt_status_print_submodule_summary(s);
        wt_status_print_untracked(s)


-- 
Ping Yin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help