Thread (11 messages) flat view 11 messages, 2 authors, 2016-06-15

Re: [PATCH v2 2/4] builtin-status: submodule summary support

From: Johannes Sixt <hidden>
Date: 2016-06-15 22:44:22

Ping Yin schrieb:
+	memset(&sm_summary, 0, sizeof(sm_summary));
+	sm_summary.argv = argv;
+	sm_summary.env = env;
+	sm_summary.git_cmd = 1;
+	sm_summary.no_stdin = 1;
+	fflush(s->fp);
+	sm_summary.out = dup(fileno(s->fp));    /* run_command closes it */
The fflush() at this point makes a lot of sense, and doesn't even need a
comment (IMHO).
 	wt_status_print_changed(s);
+	// must flush s->fp since following call will write to s->fp in a child process
+	fflush(s->fp);
+	wt_status_print_submodule_summary(s);
 	wt_status_print_untracked(s);
But then we don't need the fflush() here. Right?

-- Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help