Re: [PATCH] t9001: set TERM=dumb to prevent ANSI output

Hi,

On Fri, 7 Mar 2008, Junio C Hamano wrote:

Johannes Schindelin [off-list ref] writes:

quoted

Hi,

On Thu, 6 Mar 2008, Junio C Hamano wrote:

quoted

Junio C Hamano [off-list ref] writes:

quoted

Christian Couder [off-list ref] writes:
...

quoted

This may not work well with colored output.
In test-lib.sh line 62 there is :

[ "x$TERM" != "xdumb" ] &&
	[ -t 1 ] &&
	tput bold >/dev/null 2>&1 &&
	tput setaf 1 >/dev/null 2>&1 &&
	tput sgr0 >/dev/null 2>&1 &&
	color=t

Ahh.  Sorry about that.

Ahem, third time lucky.

Well, with this:

quoted

 t/test-lib.sh |   24 +++++++++++++++++-------

I think it is no longer worth it _not_ to special-case it.  IOW I'd prefer 
my original patch for simplicity.

Hmm.  Do you still prefer "patch individual" approach, even after
considering longer term maintainability?

Well, I am not the maintainer, and I don't envy you for that.

You are a kick-ass maintainer, so I think whatever you feel is the best 
way to proceed now, is good.

Ciao,
Dscho