Thread (4 messages) flat view 4 messages, 2 authors, 2016-06-15

Re: [PATCH] t9001: set TERM=dumb to prevent ANSI output

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:21

Possibly related (same subject, not in this thread)

Johannes Schindelin [off-list ref] writes:
Hi,

On Thu, 6 Mar 2008, Junio C Hamano wrote:
quoted
Junio C Hamano [off-list ref] writes:
quoted
Christian Couder [off-list ref] writes:
...
quoted
This may not work well with colored output.
In test-lib.sh line 62 there is :

[ "x$TERM" != "xdumb" ] &&
	[ -t 1 ] &&
	tput bold >/dev/null 2>&1 &&
	tput setaf 1 >/dev/null 2>&1 &&
	tput sgr0 >/dev/null 2>&1 &&
	color=t
Ahh.  Sorry about that.
Ahem, third time lucky.
Well, with this:
quoted
 t/test-lib.sh |   24 +++++++++++++++++-------
I think it is no longer worth it _not_ to special-case it.  IOW I'd prefer 
my original patch for simplicity.
Hmm.  Do you still prefer "patch individual" approach, even after
considering longer term maintainability?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help