Re: gitweb bug: broken "next" and other links

El 12/2/2008, a las 14:10, Jakub Narebski escribió:

Dnia wtorek 12. lutego 2008 13:24, Wincent Colaiuta napisał:

quoted

El 11/2/2008, a las 16:30, Jakub Narebski escribió:

quoted

I'm sorry. You are right. I haven't seen breakage because it shows
only when you use 'pathinfo' feature and pathinfo URLs.

Below there is a fix for that; actully only second part mentioned
(and first in patch) is needed, i.e. moving setting  
$params{'project'}
before dealing with -replay is needed I think to fix this bug.

Could you test it please?

Your patch fixes the "next" links in the shortlog and log views.

It doesn't fix the broken "raw" links in the commitdiff view. I'm
still seeing links like:

http://example.com/ARRAY(0x8c97f64)?a=commitdiff_plain;h=f29d56269a1c3bd4a970897397470f41553a64f9

Could yu please give an URL for the page containing broken
link

Any commitdiff page on repo.or.cz:

eg.

http://repo.or.cz/w/git.git?a=commitdiff;h=94bf9f7c37cca0241785a5f4e54e5cc98e175244

Any commitdiff page on my own gitweb install:

eg.

http://git.wincent.com/wikitext.git?a=commitdiff;h=f29d56269a1c3bd4a970897397470f41553a64f9

relevant parts of gitweb configuration (gitweb_config.perl),
and gitweb parts of repository configuration, if there are any?

Obviously I can't comment about the repo.or.cz config, but in my local  
install gitweb was built with:

make prefix=/usr/local \
  GITWEB_PROJECTROOT=/pub/git/path_to_public_repos \
  GITWEB_LIST=/pub/git/conf/gitweb-projects \
  GITWEB_STRICT_EXPORT=1 \
  GITWEB_CSS="/gitweb.css" \
  GITWEB_LOGO="/git-logo.png" \
  GITWEB_FAVICON="/git-favicon.png" \
  GITWEB_CONFIG="/pub/git/conf/gitweb.conf" \
  gitweb/gitweb.cgi

And gitweb.conf contains:

$feature{'search'}{'default'} = [undef];
$feature{'blame'}{'default'} = [undef];
$feature{'pickaxe'}{'default'} = [undef];
$feature{'grep'}{'default'} = [undef];
$feature{'pathinfo'}{'default'} = [1];
$my_uri = "http://git.wincent.com";
$home_link = "http://git.wincent.com/";
$site_name = "git.wincent.com";

So all pretty stock standard, I think.

Cheers,
Wincent