Re: gitweb bug: broken "next" and other links

El 11/2/2008, a las 16:30, Jakub Narebski escribió:

Dnia poniedziałek 11. lutego 2008 14:33, Wincent Colaiuta napisał:

quoted

El 11/2/2008, a las 14:02, Jakub Narebski escribió:

quoted

Wincent Colaiuta [off-list ref] writes:

quoted

Just noticed a bug (possibly bugs) in gitweb.

Look at a shortlog page like this one:

http://repo.or.cz/w/git.git?a=shortlog

Mouse over the "next" link at the bottom and you'll see this is the
URL:

http://repo.or.cz/w/ARRAY(0x85a5318)?a=shortlog;pg=1

Which obviously won't work...

This is bug in repo.or.cz version of gitweb, which is slightly
modified as compared to the "stock" version. Such error would be
catched by the gitweb 'run as standalone script and check stderr'
test script.

Hmm. I don't know. I can reproduce all three of those bugs on my own
unmodified gitweb installation from 1.5.4.

I'm sorry. You are right. I haven't seen breakage because it shows
only when you use 'pathinfo' feature and pathinfo URLs.

Below there is a fix for that; actully only second part mentioned
(and first in patch) is needed, i.e. moving setting $params{'project'}
before dealing with -replay is needed I think to fix this bug.

Could you test it please?

Your patch fixes the "next" links in the shortlog and log views.

It doesn't fix the broken "raw" links in the commitdiff view. I'm  
still seeing links like:

http://example.com/ARRAY(0x8c97f64)?a=commitdiff_plain;h=f29d56269a1c3bd4a970897397470f41553a64f9

Cheers,
Wincent