Re: [RFC,PATCH] Make git prune remove temporary packs that look like write failures

On Mon, 4 Feb 2008, Johannes Schindelin wrote:

Hi,

On Mon, 4 Feb 2008, David Tweed wrote:

quoted

+                       if(c>0 && c<4096 && stat(name, &status) == 0
+                          && status.st_mtime < now - 600){

Please have spaces after the "if" and before the "{" (just imitate the 
style of the rest of the file).

Also, 10 minutes grace period for any ongoing fetch or repack seems a bit 
arbitrary.  Maybe default to 10 minutes, and introduce 
prune.packGracePeriod?

(Which reminds me that it might be useful to add a 
prune.looseObjectsGracePeriod to avoid having to type --expire= all the 
time?)

Please use the same parameter for both.  There is no need to have 
separate settings.


Nicolas