Re: [PATCH 2/2] close_lock_file(): new function in the lockfile API

On Wed, 16 Jan 2008, Junio C Hamano wrote:

+
+void close_lock_file(struct lock_file *lk)
+{
+	close(lk->fd);
+	lk->fd = -1;
+}

Since one of the main purposes of closing would be the error testing of 
writes that haven't made it out yet on filesystems like NFS that do 
open-close cache serialization, I'd suggest doing this as

	int close_lock_file(struct lock_file *lk)
	{
		int fd = lk->fd;
		lk->df = -1;
		return close(fd);
	} 

to give the return code.

		Linus