Re: [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir()
From: Dmitry Kakurin <hidden>
Date: 2016-06-15 22:44:02
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir() · Steffen Prohaska <hidden>
- 2016-06-15 · Re: [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir() · Johannes Schindelin <hidden>
- 2016-06-15 · Re: [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir() · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir() · Steffen Prohaska <hidden>
- 2016-06-15 · Re: [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir() · Johannes Sixt <hidden>
On Jan 1, 2008 10:52 AM, Steffen Prohaska [off-list ref] wrote:
In conclusion, using setenv() as in the original code instead of
set_git_dir() should be safe and this patch is not needed.
I tend to revert the changes in msysgit and see if we hit any
problems. But I'll wait until 1.5.4 is released.
SteffenPlease don't revert this change. I've made it in response to git clone failing, commit 855f254b2b5b083a63fc8d7709a42e2cbdc5a136. -- - Dmitry