Re: [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir()
From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:43:53
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir() · Steffen Prohaska <hidden>
- 2016-06-15 · Re: [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir() · Johannes Schindelin <hidden>
- 2016-06-15 · Re: [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir() · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir() · Steffen Prohaska <hidden>
- 2016-06-15 · Re: [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir() · Johannes Sixt <hidden>
Hi, On Thu, 22 Nov 2007, Steffen Prohaska wrote:
Yes, and apparently even nobody knows how to trigger the problem on Windows.
A quick and easy way would be to instrument getenv(), unsetenv() and setenv(), which would trigger an error. Something like this (but you will have to put in a few "extern called_getenv; called_getenv = 0;", since already a simple git-init fails because of setup_path()): -- snipsnap -- [PATCH] Instrument getenv(), setenv(), unsetenv() and putenv() ... for finding places where a pointer obtained by getenv() could be invalidated later. --- environment.c | 1 + git-compat-util.h | 31 +++++++++++++++++++++++++++++++ 2 files changed, 32 insertions(+), 0 deletions(-)
diff --git a/environment.c b/environment.c
index ce75e98..027340e 100644
--- a/environment.c
+++ b/environment.c@@ -9,6 +9,7 @@ */ #include "cache.h" +int called_setenv, called_getenv; char git_default_email[MAX_GITNAME]; char git_default_name[MAX_GITNAME]; int trust_executable_bit = 1;
diff --git a/git-compat-util.h b/git-compat-util.h
index 79eb10e..a41469b 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h@@ -427,4 +427,35 @@ static inline int strtol_i(char const *s, int base, int *result) return 0; } +extern int called_setenv, called_getenv; +static inline char *test_getenv(const char *name) +{ + if (!called_setenv) + warning ("called test_getenv %s", name); + called_getenv = 1; + return getenv(name); +} +static inline int test_setenv(const char *name, const char *value, int overwrite) +{ + if (!called_setenv && called_getenv) + die ("getenv was called before setenv(%s, %s, %d)", + name, value, overwrite); + return setenv(name, value, overwrite); +} +static inline int test_unsetenv(const char *name) +{ + if (!called_setenv && called_getenv) + die ("getenv was called before unsetenv(%s)", name); + return unsetenv(name); +} +static inline int test_putenv(char *string) +{ + if (!called_setenv && called_getenv) + die ("getenv was called before putenv(%s)", string); + return putenv(string); +} +#define getenv test_getenv +#define setenv test_setenv +#define unsetenv test_unsetenv + #endif