Re: [PATCH 1/2] git-help: add "help.format" config variable.

Le jeudi 13 décembre 2007, Junio C Hamano a écrit :

Junio C Hamano [off-list ref] writes:

quoted

Christian Couder [off-list ref] writes:

quoted

diff --git a/git.c b/git.c
index 4f9876e..d46b63d 100644
--- a/git.c
+++ b/git.c

@@ -324,7 +324,7 @@ static void handle_internal_command(int argc,

const char **argv) { "gc", cmd_gc, RUN_SETUP },
 		{ "get-tar-commit-id", cmd_get_tar_commit_id },
 		{ "grep", cmd_grep, RUN_SETUP | USE_PAGER },
-		{ "help", cmd_help },
+		{ "help", cmd_help, RUN_SETUP },
 #ifndef NO_CURL
 		{ "http-fetch", cmd_http_fetch, RUN_SETUP },
 #endif

It would be _NICE_ if we read configuration when we are in a git
repository, but I am afraid this change is unnice -- the users used to
be able to say "git help" from anywhere didn't they?  Now they will get
"Not a git repository".  It needs to do an optional repository
discovery, not a mandatory one RUN_SETUP causes.

It turns out that the earlier git-browse-help is already broken with
respect to this.

You are right, I did not test outside a git repository.
I reworked the patch and will send it after this email.

While testing my new patch it seemed to me that some of your changes in the 
patch quoted below prevent some configuration variables to be used when 
they are set in the "global" config file (~/.gitconfig). So I reverted them 
in my new patch. But thanks to your other changes, it seems to work fine 
now.

-- >8 --
[PATCH] git-help -w: do not require to be in git repository

[...]

This seems to prevent using global configuration when outside a git repo.

This also.

Thanks,
Christian.