Re: [PATCH 1/2] git-help: add "help.format" config variable.
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:58
Christian Couder [off-list ref] writes:
quoted hunk
diff --git a/git.c b/git.c index 4f9876e..d46b63d 100644 --- a/git.c +++ b/git.c@@ -324,7 +324,7 @@ static void handle_internal_command(int argc, const char **argv) { "gc", cmd_gc, RUN_SETUP }, { "get-tar-commit-id", cmd_get_tar_commit_id }, { "grep", cmd_grep, RUN_SETUP | USE_PAGER }, - { "help", cmd_help }, + { "help", cmd_help, RUN_SETUP }, #ifndef NO_CURL { "http-fetch", cmd_http_fetch, RUN_SETUP }, #endif
It would be _NICE_ if we read configuration when we are in a git repository, but I am afraid this change is unnice -- the users used to be able to say "git help" from anywhere didn't they? Now they will get "Not a git repository". It needs to do an optional repository discovery, not a mandatory one RUN_SETUP causes.