Re: [PATCH] Grammar fixes for gitattributes documentation

On Thu, Nov 15, 2007 at 06:20:10PM +1100, David Symonds wrote:

quoted

quoted

quoted

quoted

+A `filter` attribute can be set to a string value which names a
filter driver specified in the configuration.

"that" should be used to introduce restrictive clauses (as you point
out), and this use should be a restrictive clause, since you can't set
the attribute to just any value--you need to set it to the value
*that* names the desired filter driver.

I don't see it as restrictive, but I can see how one would. I think it
is not a case of "this wording is correct" but rather "this wording
means one thing, and the other wording means another."

But the two meanings are likely to be interpreted the same way, so I
think it isn't a big deal (although "which" without a comma _is_ wrong
:) ).

-Peff