Re: [PATCH] Grammar fixes for gitattributes documentation

El 14/11/2007, a las 9:55, Junio C Hamano escribió:

Wincent Colaiuta [off-list ref] writes:

quoted

-A `filter` attribute can be set to a string value.  This names
+A `filter` attribute can be set to a string value which names a
filter driver specified in the configuration.

Will we get the canned "which vs that" discussion on this change?

Perhaps. Neither would be incorrect, although technically "that" is a  
tighter match.

I do appreciate the grammar fixes, but I needed to re-wrap and
swap lines to see the real change.  Especially, after this
re-wrapping, the updated lines with missing "the" fixed still
fit nicely below 70 columns and the right edge is not too ragged
to be distractive even for people who read unformatted text.

Could you please avoid this kind of unnecessary re-wrapping in
the future patches?

Ok, sorry about that. I wasn't sure of the maximum allowed length in  
the doc files, and the longest line I could find in that file was 67  
chars, so I made sure that nothing exceeded that. Will make a note  
that the official limit is 70. Perhaps this could be added to the  
style document? Will whip up a patch for that.

Cheers,
Wincent