Re: [PATCH] Mac OS X 10.5 does not require the OLD_ICONV flag set

"David Symonds" [off-list ref] writes:

On 11/2/07, Junio C Hamano [off-list ref] wrote:

quoted

Blake Ramsdell [off-list ref] writes:

quoted

Signed-off-by: Blake Ramsdell <redacted>
---
 Makefile |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 71479a2..5d83756 100644
--- a/Makefile
+++ b/Makefile

@@ -401,7 +401,9 @@ endif
 ifeq ($(uname_S),Darwin)
      NEEDS_SSL_WITH_CRYPTO = YesPlease
      NEEDS_LIBICONV = YesPlease
-     OLD_ICONV = UnfortunatelyYes
+     ifneq ($(uname_R),9.0.0)
+             OLD_ICONV = UnfortunatelyYes
+     endif
      NO_STRLCPY = YesPlease
      NO_MEMMEM = YesPlease
 endif

I do not have an access to a Darwin box, but do you mean 10.5
gives 9.0.0 as uname_R?

Further, that comparison is going to fail as soon as the next revision
of Darwin (9.0.1, etc.) is released.

Can we do something intelligent with $(shell iconv --version)
there instead, I wonder, then?