Re: [PATCH] Mac OS X 10.5 does not require the OLD_ICONV flag set

On Fri, Nov 02, 2007 at 02:03:52AM -0700, Junio C Hamano [off-list ref] wrote:

Blake Ramsdell [off-list ref] writes:

quoted

Signed-off-by: Blake Ramsdell <redacted>
---
 Makefile |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 71479a2..5d83756 100644
--- a/Makefile
+++ b/Makefile

@@ -401,7 +401,9 @@ endif
 ifeq ($(uname_S),Darwin)
 	NEEDS_SSL_WITH_CRYPTO = YesPlease
 	NEEDS_LIBICONV = YesPlease
-	OLD_ICONV = UnfortunatelyYes
+	ifneq ($(uname_R),9.0.0)
+		OLD_ICONV = UnfortunatelyYes
+	endif
 	NO_STRLCPY = YesPlease
 	NO_MEMMEM = YesPlease
 endif

I do not have an access to a Darwin box, but do you mean 10.5
gives 9.0.0 as uname_R?

Be it that or not, it looks wrong to me to check the Darwin version to
know what to use. Do you rely on the Linux kernel version to know whether
iconv is present ?

Mike