Thread (25 messages) flat view 25 messages, 8 authors, 2016-06-15

Re: [PATCH-resent] gitk: fix in procedure drawcommits

From: Paul Mackerras <hidden>
Date: 2016-06-15 22:43:43

Michele Ballabio writes:
This commit (and many others) has two parents, but the two parents
have the same hash. So gitk tries to unset the same variable twice,
hence the error. At this point, the fix for gitk should be either to
check if the parents have the same hash when reading the commit or
avoiding to unset two times the same variable.
Actually, there is a commit like that in the kernel tree, and with
this clue, I have managed to reproduce the problem on the kernel tree
with the command

	gitk v2.6.12-rc2..13e652800d1644dfedcd0d59ac95ef0beb7f3165

I have just pushed out a fix to my gitk.git tree.

Paul.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help