Re: gitk patch collection pull request

On Sat, Oct 20, 2007 at 14:00:20 +0100, Jonathan del Strother wrote:

On 20 Oct 2007, at 12:46, Paul Mackerras wrote:

quoted

Jonathan del Strother writes:

quoted

In my defense, most of that file is space indented, and the places

Only the lines that are indented 1 level start with spaces.  Any line
that is indented 2 or more levels should start with a tab.

quoted

quoted

It seems to have the whole 'tabs for code
indentation, with space for alignment' rule back-to-front.

I don't recall signing up to that rule. :)  I use 4-column indentation
and 8-column tabs, and my editor (emacs) handles it all automatically
for me.

Ugh...  I don't usually get involved in tab/space wars, but I'm curious... 
why on earth would you choose this style?

Because that's default behaviour of both emacs and vi when you set
indentation different from tabstop. Actually most of GNU software, whether it
uses the GNU standard indent of 2, or more, uses tabs for any indents
over 8. Probably even most unix software uses this.

Actually, even if the indent is 8, function arguments are often aligned under
the open parenthesis and a tabs + spaces combination is normally used for
that as well (because, again, that's what most editors will by default do!).

With space indentation you can make sure that everyone sees the indentation 
as it was intended.  With tab indentation, you save space, add semantic 
meaning, and let people control how wide they want their indents to appear. 
 This approach seems to take the worst parts of each and combine them.  
What's the benefit?

Tab stops are every 8 characters. No more, no less. Ever. This makes the text
with whatever formating you want the shortest.

I appreciate I'm not going to convert you - this is an honest question.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
						 Jan 'Bulb' Hudec [off-list ref]