Re: [PATCH] t9400: Add some tests for checkout

Hi,

On Thu, 4 Oct 2007, Frank Lichtenheld wrote:

On Thu, Oct 04, 2007 at 07:24:05PM +0100, Johannes Schindelin wrote:

quoted

On Thu, 4 Oct 2007, Frank Lichtenheld wrote:

quoted

+# clean up
+rm -fr cvswork2
+rm -fr "$SERVERDIR"
+cd "$WORKDIR" &&
+git clone -q --local --bare "$WORKDIR/.git" "$SERVERDIR" >/dev/null 2>&1 &&
+GIT_DIR="$SERVERDIR" git config --bool gitcvs.enabled true &&
+GIT_DIR="$SERVERDIR" git config gitcvs.logfile "$SERVERDIR/gitcvs.log" ||
+exit 1

Should this not be in a test_expect_success, too?

Since I do this several times and since it is easier to see what tests
it belongs to if it isn't buried in one of them, I would say "no".

Just to clarify: I meant making an own "test_expect_success", a la "setup" 
in many other test scripts.

But I'm not the maintainer, so I'll just shut up.

Ciao,
Dscho