Thread (6 messages) flat view 6 messages, 4 authors, 2016-06-15

Re: [PATCH 2/3] archive: specfile support (--pretty=format: in archive files)

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:33

Possibly related (same subject, not in this thread)

René Scharfe [off-list ref] writes:
The attribute is useful for creating auto-updating specfiles.  It is
limited by the underlying function format_commit_message(), though.
E.g. currently there is no placeholder for git-describe like output,
and expanded specfiles can't contain NUL bytes.  That can be fixed
in format_commit_message() later and will then benefit users of
git-log, too.
Interesting.  I however wonder if "specfile" is a good name for
this attribute, although I admit I do not think of anything
better offhand.
Why did it take me that long to come up with such a simple patch?
There was a vacation and a feature freeze in between, but above all
I was only recently able to convince myself (using ugly code) that
format_commit_message() can indeed be made to expand placeholders
to git-describe strings..
Thanks.  Will take a look.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help