Re: [PATCH] Fixed non portable use of expr, and incorrect use of test -eq for string comparison.

David Jack Olrik wrote:

On 22/08/2007, at 14.21, Uwe Kleine-König wrote:

quoted

David Jack Olrik wrote:

quoted

-	if test "`expr index $httpd_only /`" -eq '1' || \
+	if test "`echo $httpd_only | cut -c 1`" = '/' || \
				which $httpd_only >/dev/null

I wonder why not use:

if expr "z$httpd_only" : "z/" >/dev/null

You'd then need to check against 2 instead of 1, which I find less
obvious as we are testing for a '/' at the begining of the string.

If I understood the problem right you only need to test for the exit
code, that is the program test is not required at all.

Best regards
Uwe

-- 
Uwe Kleine-König

http://www.google.com/search?q=5%2B7