Re: [PATCH] Fixed non portable use of expr, and incorrect use of test -eq for string comparison.

On 22/08/2007, at 14.21, Uwe Kleine-König wrote:

David Jack Olrik wrote:

quoted

-	if test "`expr index $httpd_only /`" -eq '1' || \
+	if test "`echo $httpd_only | cut -c 1`" = '/' || \
 				which $httpd_only >/dev/null

I wonder why not use:

	if expr "z$httpd_only" : "z/" >/dev/null

You'd then need to check against 2 instead of 1, which I find less
obvious as we are testing for a '/' at the begining of the string.

-- 
Best regards,
David Jack Olrik [off-list ref]             http://david.olrik.dk
GnuPG fingerprint C290 0A4A 0CCC CBA8 2B37 E18D 01D2 F6EF 2E61 9894
["The first rule of Perl club is  You do not talk about Perl club"]