Re: [PATCH] git init: activate rerere by default

Hi,

On Thu, 5 Jul 2007, Junio C Hamano wrote:

Johannes Schindelin [off-list ref] writes:

quoted

.... I guess that many distros do not update their templates as often 
as the core, because they are much more likely to be modified 
distro-specifically.

Can you back that up?  Fedora and Debian seem to ship them unmodified.

No.

quoted

Further, there are some platforms which are insane enough that you 
cannot trust the executable bit, and therefore the templates are 
disabled by default.

But this still holds.

If you truly want to have rerere enabled by default, it might make sense 
to:

 * Remove "if test -d "$GIT_DIR/rr-cache" tests we have in the
   existing users;

 * Implement a new test in builtin-rerere.c, as:

   - if rerere.enabled configuration does not exist, check
     $GIT_DIR/rr-cache as before;

   - if rerere.enabled configuration is true, do not bother
     checking $GIT_DIR/rr-cache, but just do it;

   - if rerere.enabled configuration is explicitly set to false,
     never use rerere.

 * Maybe later we might change the default value for
   rerere.enabled to "true", IOW, everybody except people who
   say "[rerere] enabled = false" in their configuration
   automatically gets rerere.

Doing it in git-init, either your patch or by installing a new
template, means existing old repository would never get the
updated behaviour unless the user runs "git init" there, which
is not a very intuitive thing to do to begin with.

Well, I finally bit the apple. Will post in a minute.

Ciao,
Dscho