Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] git init: activate rerere by default

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:19

Johannes Schindelin [off-list ref] writes:
.... I guess that many 
distros do not update their templates as often as the core, because they 
are much more likely to be modified distro-specifically.
Can you back that up?  Fedora and Debian seem to ship them unmodified.
Further, there 
are some platforms which are insane enough that you cannot trust the 
executable bit, and therefore the templates are disabled by default.

All this means that the given patch would not hardly make rerere as 
widespread as I intended.
If you truly want to have rerere enabled by default, it might
make sense to:

 * Remove "if test -d "$GIT_DIR/rr-cache" tests we have in the
   existing users;

 * Implement a new test in builtin-rerere.c, as:

   - if rerere.enabled configuration does not exist, check
     $GIT_DIR/rr-cache as before;

   - if rerere.enabled configuration is true, do not bother
     checking $GIT_DIR/rr-cache, but just do it;

   - if rerere.enabled configuration is explicitly set to false,
     never use rerere.

 * Maybe later we might change the default value for
   rerere.enabled to "true", IOW, everybody except people who
   say "[rerere] enabled = false" in their configuration
   automatically gets rerere.

Doing it in git-init, either your patch or by installing a new
template, means existing old repository would never get the
updated behaviour unless the user runs "git init" there, which
is not a very intuitive thing to do to begin with.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help