Re: [PATCH] Introduce file with the common default build-time items.
From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:43:16
Eygene Ryabinkin [off-list ref] wrote:
Words 'wish' and 'tclsh' are scattered across at least three files, but they are tied to the same entities. To ease the maintenance and remove errors, these configuration items were gathered into the separate file named 'common-make-vars.def'.
...
quoted hunk ↗ jump to hunk
diff --git a/git-gui/Makefile b/git-gui/Makefile index 3de0de1..654641a 100644 --- a/git-gui/Makefile +++ b/git-gui/Makefile@@ -6,6 +6,8 @@ all:: GIT-VERSION-FILE: .FORCE-GIT-VERSION-FILE @$(SHELL_PATH) ./GIT-VERSION-GEN -include GIT-VERSION-FILE +# Default values +-include ../common-make-vars.def
A good idea to try and make these all common, but you cannot do this, or at least this part of the patch. The git-gui subdirectory of git.git is actually its own project, maintained in its own Git repository. It appears inside of git.git only as a convience for users. So I cannot reference ../common-make-vars.def as not all git-gui repositories have a git.git repository wrapped around them. -- Shawn.