Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: [PATCH] Make the installation targets a little less chatty

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:13

Possibly related (same subject, not in this thread)

Alex Riesen [off-list ref] writes:
by default. V=1 works as usual.

Signed-off-by: Alex Riesen <redacted>
---

Now it quite quiet. I tried top show every installed file, but it
wasn't an improvement at all so I decided to just show what's being
done.
I agree that the long single line that installs the commands to $(bindir)
may be somewhat annoying.

Cleaning up compilation step is one thing; by tidying up the
output it makes compiler warnings stand out.

But I do not like playing games like this in general in
installation rule.  An excerpt from your patch:
+	@echo installing programs
+	$(QUIET)$(foreach p,$(BUILT_INS), rm -f ...
This would not even let you see what got installed.  At least,
less verbose compilation step we have these days lets you see
what is being built.  I certainly would not object if the output
would look like this, though:

	CC builtin-cat-file.o
        ...
        GEN git-add--interactive
        ...
        LINK git-http-push
        ...
        BUILTIN git-add
        ...
	MKDIR -p /usr/local/bin
        INSTALL git-foo
        INSTALL git-bar
	...
        INSTALL templates/description
        INSTALL templates/hooks/post-update
        ...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help