Re: [PATCH] Make the installation targets a little less chatty
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:14
Alex Riesen [off-list ref] writes:
by default. V=1 works as usual. Signed-off-by: Alex Riesen <redacted> --- Updated. BTW, where does "no $(call) in Makefile" came from? It could simplify the thing a lot
Probably, but first let's make it "work right" while not introducing new stuff.
quoted hunk
diff --git a/Makefile b/Makefile index cac0a4a..6409b9c 100644 --- a/Makefile +++ b/Makefile...@@ -972,34 +975,53 @@ check: common-cmds.h ### Installation rules +ifeq ($(QUIET),@) +INST_0 = arg= +INST_1 = &&echo " INSTALL $$arg"&&$(INSTALL) "$$arg" # space +BSETUP_0 = arg= +BSETUP_1 = &&echo " SETUP BUILTIN $$arg"&& \ + rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/'"$$arg" && \ + ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git$(X)' \ + '$(DESTDIR_SQ)$(gitexecdir_SQ)/'"$$arg" # space +else +INST_0 = $(INSTALL) # space to separate "install" and its first arg +INST_1 = +BSETUP_0 = arg= +BSETUP_1 = &&rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/'"$$arg" && \ + ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git$(X)' \ + '$(DESTDIR_SQ)$(gitexecdir_SQ)/'"$$arg" # space +endif + install: all $(INSTALL) -d -m755 '$(DESTDIR_SQ)$(bindir_SQ)' $(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)'
I found Shawn's "DEST = $this_directory" quite decent. Forgot to port it?