Re: [PATCH] Fix signedness on return value from xread()

Johan Herland [off-list ref] wrote:

The return value from xread() is ssize_t. 
Paolo Teti [off-list ref] pointed out that in this case, the 
signed return value was assigned to an unsigned type (size_t). This patch 
fixes that.

Thanks for fixing this.  Its rather embarrassing as:

  commit 00be8dcc1aca3c1c1a94b39f0563d30d1fa89290
  Author: Sami Farin [off-list ref]
  Date:   Tue Apr 24 22:56:02 2007 +0300
  
      fast-import: size_t vs ssize_t
      
      size_t is unsigned, so (n < 0) is never true.
      
      Signed-off-by: Shawn O. Pearce [off-list ref]

was applied by me to fix this very bug and I also applied the
patch that created the buggy copy in pack-write.c.

-- 
Shawn.