Thread (7 messages) flat view 7 messages, 4 authors, 2016-06-15
DORMANTno replies

[PATCH] Fix signedness on return value from xread()

From: Johan Herland <hidden>
Date: 2016-06-15 22:43:10
Subsystem: the rest · Maintainer: Linus Torvalds

The return value from xread() is ssize_t. 
Paolo Teti [off-list ref] pointed out that in this case, the 
signed return value was assigned to an unsigned type (size_t). This patch 
fixes that.

Signed-off-by: Johan Herland <redacted>
---

Using this as an opportunity to get used to sending patches... :)

Is this what you were looking for, Paolo?

 pack-write.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/pack-write.c b/pack-write.c
index de72f44..ae2e481 100644
--- a/pack-write.c
+++ b/pack-write.c
@@ -25,7 +25,7 @@ void fixup_pack_header_footer(int pack_fd,
 
 	buf = xmalloc(buf_sz);
 	for (;;) {
-		size_t n = xread(pack_fd, buf, buf_sz);
+		ssize_t n = xread(pack_fd, buf, buf_sz);
 		if (!n)
 			break;
 		if (n < 0)
-- 
1.5.1.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help