Re: [PATCH 2/2] Add --ignore-notfound option to exit with zero status when no files are removed.
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:04
Steven Grimm [off-list ref] writes:
Documentation/git-rm.txt | 3 +++ builtin-rm.c | 21 +++++++++++++++++---- t/t3600-rm.sh | 4 ++++ 3 files changed, 24 insertions(+), 4 deletions(-)
I find it easier to see what is going on with two independent features separated out, especially with tests. Much nicer.
quoted hunk
@@ -47,6 +47,9 @@ OPTIONS the paths only from the index, leaving working tree files. +\--ignore-notfound:: + Exit with a zero status even if no files matched. +
ls-files has --error-unmatch so we may want to make the name consistent by saying --ignore-unmatch? I particularly do not care about the minute naming issues _right_ _now_, but we might regret it in the long run. No need to resend unless you have an actual fix; I'll queue your patch as is in 'pu', wait for a few days for comments on the naming, and amend it as needed. Thanks.