Re: [PATCH 2/2] Add --ignore-notfound option to exit with zero status when no files are removed.

3 messages, 3 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 2/2] Add --ignore-notfound option to exit with zero status when no files are removed.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:04

Steven Grimm [off-list ref] writes:
 Documentation/git-rm.txt |    3 +++
 builtin-rm.c             |   21 +++++++++++++++++----
 t/t3600-rm.sh            |    4 ++++
 3 files changed, 24 insertions(+), 4 deletions(-)
I find it easier to see what is going on with two independent
features separated out, especially with tests.  Much nicer.
quoted hunk
@@ -47,6 +47,9 @@ OPTIONS
 	the paths only from the index, leaving working tree
 	files.
 
+\--ignore-notfound::
+	Exit with a zero status even if no files matched.
+
ls-files has --error-unmatch so we may want to make the name
consistent by saying --ignore-unmatch?  I particularly do not
care about the minute naming issues _right_ _now_, but we might
regret it in the long run.

No need to resend unless you have an actual fix; I'll queue your
patch as is in 'pu', wait for a few days for comments on the
naming, and amend it as needed.

Thanks.

Re: [PATCH 2/2] Add --ignore-notfound option to exit with zero status when no files are removed.

From: Steven Grimm <hidden>
Date: 2016-06-15 22:43:04

Junio C Hamano wrote:
ls-files has --error-unmatch so we may want to make the name
consistent by saying --ignore-unmatch?  I particularly do not
care about the minute naming issues _right_ _now_, but we might
regret it in the long run.
  
Sure, UI consistency is a good thing. Feel free to amend.

-Steve

Re: [PATCH 2/2] Add --ignore-notfound option to exit with zero status when no files are removed.

From: Jeff King <hidden>
Date: 2016-06-15 22:43:04

On Mon, Apr 16, 2007 at 12:59:35AM -0700, Junio C Hamano wrote:
quoted
+\--ignore-notfound::
+	Exit with a zero status even if no files matched.
+
ls-files has --error-unmatch so we may want to make the name
consistent by saying --ignore-unmatch?  I particularly do not
care about the minute naming issues _right_ _now_, but we might
regret it in the long run.
Isn't this quite similar to the '-k' option to git-mv?

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help