Re: [PATCH] Rename warn() to warning() to fix symbol conflicts on BSD and Mac OS

Theodore Ts'o [off-list ref] writes:

This fixes a problem reported by Randal Schwartz:

quoted

I finally tracked down all the (albeit inconsequential) errors I was getting
on both OpenBSD and OSX.  It's the warn() function in usage.c.  There's
warn(3) in BSD-style distros.  It'd take a "great rename" to change it, but if
someone with better C skills than I have could do that, my linker and I would
appreciate it.

It was annoying to me, too, when I was doing some mergetool testing on
Mac OS X, so here's a fix.

I'd take this for now, but I wonder where we should stop.  If
somebody exports error() or die(), would we end up renaming them
to git_error() and git_die()?