Re: [PATCH] Added make options NO_GUI and WITH_P4IMPORT.

Hi,

On Wed, 21 Mar 2007, Eygene Ryabinkin wrote:

Wed, Mar 21, 2007 at 12:16:40PM +0100, Johannes Schindelin wrote:

quoted

quoted

Will try to implement. But still, NO_GUI should ban the GUI tools from 
being built and installed, because user can have the Tcl/Tk available, 
but have no intention to use the git GUI. Am I right?

I am not quite certain if I agree. With a similar reasoning, you could 
introduce a flag to prevent pull-request from being installed, and 
git-tag, or other rarely used functions. Is it so bad to have gitk and 
git-gui installed?

I am happening to develop on some machines on which I have no
X-Windows or any GUI providers at all, so I prefer not to have the
Tcl/Tk dependency at all.

My point (and I think it's the same point as Jakub's) is that NO_GUI is a 
misnomer. It should be NO_TCL, since the only reason you state to skip 
installation of these parts is that they depend on X11, which is not 
installed on the machine.

If you don't do something, it is often interesting to state why: if you 
don't install something to prevent a dependency you don't want to have, it 
is different from saying that you do not want to have a GUI, _even if_ the 
dependency is there already.

Conclusion: I am in favour of NO_TCL, but not of NO_GUI.

Ciao,
Dscho