Re: [PATCH 4/4] Add a basic test case for git send-email, and fix some real bugs discovered.

On Tue, May 30, 2006 at 03:23:30PM +0200, Alex Riesen wrote:

quoted

--- a/git-send-email.perl
+++ b/git-send-email.perl

@@ -387,7 +387,9 @@ X-Mailer: git-send-email $gitversion
               my $pid = open my $sm, '|-';
               defined $pid or die $!;
               if (!$pid) {
-                       exec($smtp_server,'-i',@recipients) or die $!;

This construction (perl pipe+fork) will not work on ActiveState Perl
(it does not even parse the construct).
Last time the problem arised it was suggested to replace readers
with "qx{command}". Regretfully there were no writer case back
then. I'd suggest using IPC::Open2 for portability. Like this:

use IPC::Open2;
my $fw;
my $pid = open2(">&1", $fw, "perl", "-w");
print $fw "exit 0\n";
close($fw);'

But I wont. It was never portable in windows, no matter how hard
I tried. The best result was getting output from "cat -v", but "cat"
froze afterwards anyway, as "wc" or "perl" did. Besides, it the
command often freezes that poor imitation of xterm windows has.

I assume that "the poor imitation of xterm" is referring to cygwin's
xterm here.  It's really too bad that you can't get into the mindset of
reporting problems to the cygwin mailing list when you notice them.

I can't comment on the proposed patch since, AFAIK, using cat, wc, and
(cygwin's) perl should all work just fine but I don't think it is ever
correct to complain about a platform in released software.

cgf