Re: [PATCH 4/4] Add a basic test case for git send-email, and fix some real bugs discovered.
From: Alex Riesen <hidden>
Date: 2016-06-15 22:42:28
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH 4/4] Add a basic test case for git send-email, and fix some real bugs discovered. · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH 4/4] Add a basic test case for git send-email, and fix some real bugs discovered. · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH 4/4] Add a basic test case for git send-email, and fix some real bugs discovered. · Ryan Anderson <hidden>
quoted hunk ↗ jump to hunk
--- a/git-send-email.perl +++ b/git-send-email.perl@@ -387,7 +387,9 @@ X-Mailer: git-send-email $gitversion my $pid = open my $sm, '|-'; defined $pid or die $!; if (!$pid) { - exec($smtp_server,'-i',@recipients) or die $!;
This construction (perl pipe+fork) will not work on ActiveState Perl
(it does not even parse the construct).
Last time the problem arised it was suggested to replace readers
with "qx{command}". Regretfully there were no writer case back
then. I'd suggest using IPC::Open2 for portability. Like this:
use IPC::Open2;
my $fw;
my $pid = open2(">&1", $fw, "perl", "-w");
print $fw "exit 0\n";
close($fw);'
But I wont. It was never portable in windows, no matter how hard
I tried. The best result was getting output from "cat -v", but "cat"
froze afterwards anyway, as "wc" or "perl" did. Besides, it the
command often freezes that poor imitation of xterm windows has.
There is also 2-argument "open" with damn careful quoting,
if anyone cares (dont think anyone does, for windows).
How about disabling the test on cygwin? (patch attached). Attachments
- 0001-disable-send-email-test-for-cygwin.txt [text/plain] 731 bytes · preview