Re: [PATCH] C version of git-count-objects

On Thu, Apr 27, 2006 at 03:39:14PM -0400, Nicolas Pitre wrote:

On Thu, 27 Apr 2006, Junio C Hamano wrote:

quoted

Nicolas Pitre [off-list ref] writes:

quoted

On Thu, 27 Apr 2006, Peter Hagervall wrote:

quoted

Answering the call Linus made[1], sort of, but for a completely
different program.

Anyway, it ought to be at least as portable as the shell script, and a
whole lot faster, however much that matters.

[...]

quoted

+	for (i = 0; i < 16; i++) {
+		subdir[0] = hex_digits[i];
+		for (j = 0; j < 16; j++) {
+			subdir[1] = hex_digits[j];
+			if (access(subdir, R_OK | X_OK))
+				continue;
+			chdir(subdir);
+			if (!(dp = opendir("."))) {
+				error("can't open subdir %s", subdir);
+				continue;
+			}

Looks like you're missing a chdir(".."); there.

Why would you even _need_ to chdir() anywhere, anyway?

To avoid appending the filename to the path before each lstat() I'd 
guess.

Yes, that's pretty much the reason.

	Peter