Thread (5 messages) flat view 5 messages, 4 authors, 2016-06-15

Re: [PATCH] C version of git-count-objects

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:42:24

Nicolas Pitre [off-list ref] writes:
On Thu, 27 Apr 2006, Peter Hagervall wrote:
quoted
Answering the call Linus made[1], sort of, but for a completely
different program.

Anyway, it ought to be at least as portable as the shell script, and a
whole lot faster, however much that matters.
[...]
quoted
+	for (i = 0; i < 16; i++) {
+		subdir[0] = hex_digits[i];
+		for (j = 0; j < 16; j++) {
+			subdir[1] = hex_digits[j];
+			if (access(subdir, R_OK | X_OK))
+				continue;
+			chdir(subdir);
+			if (!(dp = opendir("."))) {
+				error("can't open subdir %s", subdir);
+				continue;
+			}
Looks like you're missing a chdir(".."); there.
Why would you even _need_ to chdir() anywhere, anyway?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help