Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl
From: Joe Perches <joe@perches.com>
Date: 2007-08-17 02:13:27
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2007-08-17 · Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl · Rene Herman <hidden>
- 2007-08-16 · Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl · Joe Perches <joe@perches.com>
- 2007-08-16 · Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl · Junio C Hamano <hidden>
- 2007-08-16 · Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl · Rene Herman <hidden>
- 2007-08-16 · Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl · Al Viro <hidden>
On Tue, 2007-08-14 at 18:31 -0700, Junio C Hamano wrote:
On the other hand, git-send-email _is_ all about sending it out, and it needs to know who your patch should reach. I think it makes sense to have one script that, given a set of paths that are affected, gives a list of potentially interested people (that is "Finding" part -- and I see there are 600+ patches to implement this on the list), and a new option to git-send-email to (1) inspect the patch to see what paths are affected, and (2) call that "Find" script to figure out whom to send it to, and probably asking for confirmation.
Sorry, not a git developer, so the paths are wrong. This seems to work: Example: git-send-email \ --cc-cmd "perl scripts/get_maintainers.pl -non -multiline" foo.diff
--- git-send-email.pl 2007-08-16 19:06:07.000000000 -0700
+++ /usr/local/bin/git-send-email 2007-05-01 11:59:14.000000000 -0700@@ -47,9 +47,6 @@ Options: --cc Specify an initial "Cc:" list for the entire series of emails. - --cc-cmd Specify a command to execute per file which adds - per file specific cc address entries - --bcc Specify a list of email addresses that should be Bcc: on all the emails.
@@ -143,7 +140,7 @@ my (@to,@cc,@initial_cc,@bcclist,@xh, # Behavior modification variables my ($chain_reply_to, $quiet, $suppress_from, $no_signed_off_cc, - $dry_run, $cc_cmd) = (1, 0, 0, 0, 0, 0); + $dry_run) = (1, 0, 0, 0, 0); my $smtp_server; my $envelope_sender;
@@ -176,7 +173,6 @@ my $rc = GetOptions("from=s" => \$from, "subject=s" => \$initial_subject, "to=s" => \@to, "cc=s" => \@initial_cc, - "cc-cmd=s" => \$cc_cmd, "bcc=s" => \@bcclist, "chain-reply-to!" => \$chain_reply_to, "smtp-server=s" => \$smtp_server,
@@ -611,16 +607,6 @@ foreach my $t (@files) { } } close F; - - if (${cc_cmd} ne "") { - my $output = `${cc_cmd} $t`; - my @lines = split("\n", $output); - foreach my $c (@lines) { - push @cc, $c; - printf("(sob) Adding cc: %s from cc-cmd: '%s'\n", $c, $t) unless $quiet; - } - } - if (defined $author_not_sender) { $author_not_sender = unquote_rfc2047($author_not_sender); $message = "From: $author_not_sender\n\n$message";