Thread (18 messages) 18 messages, 3 authors, 2026-09-03

Re: [PATCH 4/4] net/qede: remove unused app version variable

flat view

From: David Marchand <hidden>
Date: 2026-08-27 09:08:25

On Thu, 27 Aug 2026 at 02:00, Stephen Hemminger
[off-list ref] wrote:
qed_dbg_set_app_ver() validates the caller's version and stores it.
But the variable s_app_ver is never used in DPDK driver.

clang 23 reports:

  qede_debug.c:820:12: warning: variable 's_app_ver' set but not used
        [-Wunused-but-set-global]

Remove the variable and the dead store.
Maybe go one step further?
qed_dbg_set_app_ver() looks useless.
Fixes: ec55c118792b ("net/qede: add infrastructure for debug data collection")
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

-- 
David Marchand
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help