[PATCH 4/4] net/qede: remove unused app version variable
COLD32d
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2026-08-27 00:00:13
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
qed_dbg_set_app_ver() validates the caller's version and stores it.
But the variable s_app_ver is never used in DPDK driver.
clang 23 reports:
qede_debug.c:820:12: warning: variable 's_app_ver' set but not used
[-Wunused-but-set-global]
Remove the variable and the dead store.
Fixes: ec55c118792b ("net/qede: add infrastructure for debug data collection")
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/qede/qede_debug.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/net/qede/qede_debug.c b/drivers/net/qede/qede_debug.c
index 1d3147b724..8afaa5c108 100644
--- a/drivers/net/qede/qede_debug.c
+++ b/drivers/net/qede/qede_debug.c@@ -812,13 +812,6 @@ static struct split_type_defs s_split_type_defs[] = { {"vf"} }; -/******************************** Variables *********************************/ - -/** - * The version of the calling app - */ -static u32 s_app_ver; - /**************************** Private Functions ******************************/ /* Reads and returns a single dword from the specified unaligned buffer */
@@ -4869,8 +4862,6 @@ enum dbg_status qed_dbg_set_app_ver(u32 ver) if (ver < TOOLS_VERSION) return DBG_STATUS_UNSUPPORTED_APP_VERSION; - s_app_ver = ver; - return DBG_STATUS_OK; }
--
2.53.0