RE: [PATCH v1 1/3] fix PMD wording typo
From: Walsh, Conor <hidden>
Date: 2021-11-22 08:54:54
Hi Sean, A few minor nits, TBH not sure if they should be changed in this patch as this patch is just removing "driver" and correcting capitalisation of PMD. <snip>
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/hns3/hns3_ethdev.hb/drivers/net/hns3/hns3_ethdev.h index 6d30125dcc..488fe8dbbc 100644--- a/drivers/net/hns3/hns3_ethdev.h +++ b/drivers/net/hns3/hns3_ethdev.h@@ -465,7 +465,7 @@ struct hns3_queue_intr { * enable Rx interrupt. * * - HNS3_INTR_MAPPING_VEC_ALL - * PMD driver can map/unmmap all interrupt vectors with queuesWhen + * PMD can map/unmmap all interrupt vectors with queues When
"When" shouldn't be capitalised here.
* Rx interrupt in enabled.
in => is
*/ uint8_t mapping_mode;
<snip>
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/hns3/hns3_ethdev_vf.cb/drivers/net/hns3/hns3_ethdev_vf.c index d8a99693e0..7d6e251bbe 100644--- a/drivers/net/hns3/hns3_ethdev_vf.c +++ b/drivers/net/hns3/hns3_ethdev_vf.c@@ -232,7 +232,7 @@ hns3vf_set_default_mac_addr(struct rte_eth_dev*dev, HNS3_TWO_ETHER_ADDR_LEN, true, NULL, 0); if (ret) { /* - * The hns3 VF PMD driver depends on the hns3 PF kernel ethdev + * The hns3 VF PMD depends on the hns3 PF kernel ethdev * driver. When user has configured a MAC address for VF device * by "ip link set ..." command based on the PF device, the hns3 * PF kernel ethdev driver does not allow VF driver to request@@ -312,9 +312,9 @@ hns3vf_set_promisc_mode(struct hns3_hw *hw,bool en_bc_pmc, req = (struct hns3_mbx_vf_to_pf_cmd *)desc.data; /* - * The hns3 VF PMD driver depends on the hns3 PF kernel ethdev driver, + * The hns3 VF PMD depends on the hns3 PF kernel ethdev driver, * so there are some features for promiscuous/allmulticast mode in hns3 - * VF PMD driver as below: + * VF PMD as below: * 1. The promiscuous/allmulticast mode can be configured successfully * only based on the trusted VF device. If based on the non trusted * VF device, configuring promiscuous/allmulticast mode will fail.@@ -322,14 +322,14 @@ hns3vf_set_promisc_mode(struct hns3_hw *hw,bool en_bc_pmc, * kernel ethdev driver on the host by the following command: * "ip link set <eth num> vf <vf id> turst on" * 2. After the promiscuous mode is configured successfully, hns3 VF PMD - * driver can receive the ingress and outgoing traffic. In the words, + * can receive the ingress and outgoing traffic. In the words,
"In the words" doesn't make any sense here even, "In other words," doesn't really work either.
* all the ingress packets, all the packets sent from the PF and * other VFs on the same physical port. * 3. Note: Because of the hardware constraints, By default vlan filter * is enabled and couldn't be turned off based on VF device, so vlan * filter is still effective even in promiscuous mode. If upper * applications don't call rte_eth_dev_vlan_filter API function to - * set vlan based on VF device, hns3 VF PMD driver will can't receive + * set vlan based on VF device, hns3 VF PMD will can't receive * the packets with vlan tag in promiscuoue mode. */ hns3_cmd_setup_basic_desc(&desc, HNS3_OPC_MBX_VF_TO_PF, false);
With or without these changes: Reviewed-by: Conor Walsh <redacted> Thanks, Conor.