Re: [dpdk-dev] [RFC PATCH v2] raw/ptdma: introduce ptdma driver
From: Sebastian, Selwin <hidden>
Date: 2021-10-28 14:54:45
[AMD Official Use Only] Hi, I am working on making ptdma driver as a dmadev. Will submit new patch for review. Thanks and Regards Selwin Sebastian -----Original Message----- From: Thomas Monjalon <redacted> Sent: Wednesday, October 27, 2021 8:29 PM To: Sebastian, Selwin <redacted> Cc: dev@dpdk.org; David Marchand <redacted> Subject: Re: [dpdk-dev] [RFC PATCH v2] raw/ptdma: introduce ptdma driver [CAUTION: External Email] Any update please? 06/09/2021 19:17, David Marchand:
On Mon, Sep 6, 2021 at 6:56 PM Selwin Sebastian [off-list ref] wrote:quoted
Add support for PTDMA driver- This description is rather short. Can this new driver be implemented as a dmadev? See (current revision): https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc hwork.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D18677%26state%3D% 252A%26archive%3Dboth&data=04%7C01%7Cselwin.sebastian%40amd.com%7C 5ed560abb6e442d8b53108d9995a57ad%7C3dd8961fe4884e608e11a82d994e183d%7C 0%7C0%7C637709435600817110%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDA iLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=a%2FX cY1WBb1zzuAxtODkvYdg0jHFBue7HBULapymhrhk%3D&reserved=0 - In any case, quick comments on this patch: Please update release notes. vfio-pci should be preferred over igb_uio. Please check indent in meson. ABI version is incorrect in version.map. RTE_LOG_REGISTER_DEFAULT should be preferred. The patch is monolithic, could it be split per functionnality to ease review? Copy relevant maintainers and/or (sub-)tree maintainers to make them aware of this work, and get those patches reviewed. Please submit new revisions of patchsets with increased revision number in title + changelog that helps track what changed between revisions. Some of those points are described in: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdoc. dpdk.org%2Fguides%2Fcontributing%2Fpatches.html&data=04%7C01%7Csel win.sebastian%40amd.com%7C5ed560abb6e442d8b53108d9995a57ad%7C3dd8961fe 4884e608e11a82d994e183d%7C0%7C0%7C637709435600817110%7CUnknown%7CTWFpb GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 %3D%7C1000&sdata=8TIG%2B8uXgz2DIwTHt69YKklYc3%2By3UdxGJ4deKG19iw%3 D&reserved=0 Thanks.