Re: [dpdk-dev] [RFC PATCH v2] raw/ptdma: introduce ptdma driver
From: David Marchand <hidden>
Date: 2021-09-06 17:18:03
On Mon, Sep 6, 2021 at 6:56 PM Selwin Sebastian [off-list ref] wrote:
Add support for PTDMA driver
- This description is rather short. Can this new driver be implemented as a dmadev? See (current revision): https://patchwork.dpdk.org/project/dpdk/list/?series=18677&state=%2A&archive=both - In any case, quick comments on this patch: Please update release notes. vfio-pci should be preferred over igb_uio. Please check indent in meson. ABI version is incorrect in version.map. RTE_LOG_REGISTER_DEFAULT should be preferred. The patch is monolithic, could it be split per functionnality to ease review? Copy relevant maintainers and/or (sub-)tree maintainers to make them aware of this work, and get those patches reviewed. Please submit new revisions of patchsets with increased revision number in title + changelog that helps track what changed between revisions. Some of those points are described in: https://doc.dpdk.org/guides/contributing/patches.html Thanks. -- David Marchand