Re: [dpdk-dev] [PATCH v7 1/5] net/virtio: implement rte_power_monitor API
From: Ferruh Yigit <hidden>
Date: 2021-10-21 16:59:14
On 10/18/2021 3:16 PM, Miao Li wrote:
This patch implements rte_power_monitor API in virtio PMD to reduce power consumption when no packet come in. According to current semantics of power monitor, this commit adds a callback function to decide whether aborts the sleep by checking current value against the expected value and virtio_get_monitor_addr to provide address to monitor. When no packet come in, the value of address will not be changed and the running core will sleep. Once packets arrive, the value of address will be changed and the running core will wakeup.
A minor comment but instead of patch title mentioning what is implemented, better to describe what feature is added, like: net/virtio: support power monitor
quoted hunk ↗ jump to hunk
Signed-off-by: Miao Li <redacted> Reviewed-by: Chenbo Xia <redacted> --- doc/guides/rel_notes/release_21_11.rst | 4 ++ drivers/net/virtio/virtio_ethdev.c | 56 ++++++++++++++++++++++++++ 2 files changed, 60 insertions(+)diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst index d5435a64aa..c298844898 100644 --- a/doc/guides/rel_notes/release_21_11.rst +++ b/doc/guides/rel_notes/release_21_11.rst@@ -80,6 +80,10 @@ New Features Added macros ETH_RSS_IPV4_CHKSUM and ETH_RSS_L4_CHKSUM, now IPv4 and TCP/UDP/SCTP header checksum field can be used as input set for RSS. +* **Updated virtio PMD.** + + Implement rte_power_monitor API in virtio PMD. +
The release note updates are grouped as described in the documents section comment, and in a group it is sorted alphabetically, can you please re-arrange the update accordingly. And similar comment, instead of documenting what API implemented, you can mention what support is added. Same comment for other patches in the set.