Hi Chenbo,

-----Original Message-----
From: Xia, Chenbo <redacted>
Sent: Wednesday, September 29, 2021 11:03 AM
To: Li, Miao <redacted>; dev@dpdk.org
Cc: maxime.coquelin@redhat.com
Subject: RE: [PATCH v3 4/5] power: modify return of queue_stopped

quoted

-----Original Message-----
From: Li, Miao <redacted>
Sent: Friday, September 24, 2021 6:23 PM
To: dev@dpdk.org
Cc: Xia, Chenbo <redacted>; maxime.coquelin@redhat.com; Li,

Miao

quoted

[off-list ref]
Subject: [PATCH v3 4/5] power: modify return of queue_stopped

Since some vdevs like virtio and vhost do not support rxq_info_get and
queue state inquiry, the error return value -ENOTSUP need to be ignored
when queue_stopped cannot get rx queue information and rx queue state.
This patch changes the return value of queue_stopped when
rte_eth_rx_queue_info_get return ENOTSUP to support vdevs which cannot
provide rx queue information and rx queue state enable power management.

Signed-off-by: Miao Li <redacted>
---
 lib/power/rte_power_pmd_mgmt.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/lib/power/rte_power_pmd_mgmt.c

b/lib/power/rte_power_pmd_mgmt.c

quoted

index 0ce40f0875..39a2b4cd23 100644

--- a/lib/power/rte_power_pmd_mgmt.c
+++ b/lib/power/rte_power_pmd_mgmt.c

@@ -382,8 +382,13 @@ queue_stopped(const uint16_t port_id, const

uint16_t

quoted

queue_id)
 {
 	struct rte_eth_rxq_info qinfo;

-	if (rte_eth_rx_queue_info_get(port_id, queue_id, &qinfo) < 0)
-		return -1;
+	int ret = rte_eth_rx_queue_info_get(port_id, queue_id, &qinfo);
+	if (ret < 0) {
+		if (ret == -ENOTSUP)
+			return 1;
+		else
+			return -1;
+	}

 	return qinfo.queue_state == RTE_ETH_QUEUE_STATE_STOPPED;
 }
--
2.25.1

Anatoly's ACK is missed.

I will add it in the next version.

Thanks,
Miao